[QL] Don't Allow Empty String For `payer_email` in One-Time Checkout

braintree / braintree_ios

Braintree SDK for iOS

https://developer.paypal.com/braintree/docs/start/hello-client/ios/v5

MIT License

557 stars 291 forks source link

[QL] Don't Allow Empty String For `payer_email` in One-Time Checkout #1301

Closed agedd closed 2 months ago

agedd commented 2 months ago

Summary of changes

If the userAuthenticalEmail, do not set the payer_email field in the BTPayPalCheckoutRequest for one-time checkout flows.
This change only applies to the one-time checkout flows and not the vault flows.

Checklist

[ ]~Added a changelog entry~

Authors

List GitHub usernames for everyone who contributed to this pull request.

@agedd

stechiu commented 2 months ago

Can you add an alert popup notification or something that let's someone know what to do instead? Otherwise the user will keep trying to send an empty string

jaxdesmarais commented 2 months ago

Removed the ticket link since we don't want internal links in public GitHub

agedd commented 2 months ago

Can you add an alert popup notification or something that let's someone know what to do instead? Otherwise the user will keep trying to send an empty string

this is a good callout, afaik the ask was to prevent including the payer_email field if the user email is empty, so that the backend create_payment_resource GW API does not fail - will follow-up with product on this.