search

braintree / braintree_ios

Braintree SDK for iOS
https://developer.paypal.com/braintree/docs/start/hello-client/ios/v5
MIT License
556 stars 290 forks source link

[QL] Remove Stage Logic from `PayPalWebCheckoutViewController` #1320

Closed jaxdesmarais closed 1 month ago

jaxdesmarais commented 1 month ago

Summary of changes

Checklist

Authors

stechiu commented 1 month ago

Out of curiosity, why are we removing staging?

jaxdesmarais commented 1 month ago

Out of curiosity, why are we removing staging?

We only had it in our demo app in the first place because sandbox and production for this feature was not released. Now that we can test in sandbox and production, we don't need to keep this around. Eventually the logic will be removed from the GW for this and our deployed backing services will expire so better for us to clean this up before merging to main.

tdchow commented 1 month ago

Would we ever have a long-term need to support running the demo app in stage?

jaxdesmarais commented 1 month ago

Would we ever have a long-term need to support running the demo app in stage?

Potentially, but it'd require some work on the gateway side to keep the backing services active. It'd also require us to only use 1 account for all features in stage. For example, this key is specifically built out to only work with the app switch flow, so would need some rework to support all the flows.