Server responds 404 if empty string used as merchant_id, public and private keys

braintree / braintree_java

Braintree Java library

https://developer.paypal.com/braintree/docs/start/overview

MIT License

158 stars 99 forks source link

Server responds 404 if empty string used as merchant_id, public and private keys #19

Closed garagatyi closed 7 years ago

garagatyi commented 10 years ago

It is more about server behavior than java client.

I've had misconfiguration. Merchant id, public, private keys was set as empty strings. I tried add credit card to user, add subscriptions and server responded 404.

It would be better to respond 400 Bad request with meaningful error message.

jdlc commented 8 years ago

Hi @garagatyi, Thanks for your feedback and I'm sorry it took us so long to respond. This is a good idea and we've explored implementations to solve this across our client libraries for a possible future release. We will provide any updates in this thread. Thanks again!

danakatz commented 7 years ago

Starting in 2.69.0, released today, empty strings will return a ConfigurationError with a descriptive message about what's missing. Once again, we appreciate the feedback and thank you for your patience!