search

braintree / braintree_java

Braintree Java library
https://developer.paypal.com/braintree/docs/start/overview
MIT License
158 stars 98 forks source link

Performance/safety tweaks to networking code #20

Closed gsharma closed 8 years ago

gsharma commented 9 years ago
  1. Do not keep initializing SSLSocketFactory in https request scope.
  2. Carefully close network streams, drain connections.
openbl commented 9 years ago

Thanks, @gsharma.

To close the loop, we have discussed this out of band of this PR. This PR looks like a good improvement to the library from Braintree's perspective. We are going to discuss this internally before we integrate it into our library.

danakatz commented 8 years ago

@gsharma Both of these changes have been incorporated - the second change you listed (closing network streams) went out with 2.39.2 and the first (reusing SSLSocketFactory) will be included in the next release. Thanks for your contribution and we appreciate your patience!

omgrr commented 8 years ago

@gsharma Happy to report that reusing the SSLSocketFactory went out with 2.66.0. Thanks!