search

braintree / braintree_java

Braintree Java library
https://developer.paypal.com/braintree/docs/start/overview
MIT License
158 stars 98 forks source link

Added logging feature #39

Closed yatsenko-ihor closed 8 years ago

yatsenko-ihor commented 8 years ago

We implemented logging feature accordingly to your requirements: 1) Please leverage Java's built-in Logger class. We aim to be compatible with Java 6, so please do not use any features that are not present in Java 6. 2) We attempt to keep our Libraries as idiomatic as possible across different languages. We already have an implementation for logging in our Ruby client library. Please follow the implementation in configuration.rb and http.rb as closely as possible.

Please review it. Thank you.

omgrr commented 8 years ago

Thanks @yatsenko-ihor this looks great! We're going to start adding some tests around it and will let you know if we have any questions or news.

iamvlads commented 8 years ago

Hi @omgrr, is there any ETA when it can be merged to the master? It's really important for us to have this changes for our project.

Thanks in advance.

omgrr commented 8 years ago

I can't provide an ETA, but I have started working on this. I will keep you updated, thanks!

iamvlads commented 8 years ago

Hi @omgrr, are there any news?

Thanks

omgrr commented 8 years ago

Hey @vsinjavin we're still working on it. There are still a couple of more tests that we need to add before we merge this.

omgrr commented 8 years ago

This has been added in 2.57.0. Thanks again for your contribution and patience!