search

braintree / braintree_java

Braintree Java library
https://developer.paypal.com/braintree/docs/start/overview
MIT License
158 stars 98 forks source link

Update NodeWrapper.java #50

Closed aaomidi closed 7 years ago

aaomidi commented 7 years ago

These two methods are the exact same.

jackellenberger commented 7 years ago

Hi @aaomidi,

The two are very similar, however there is a very subtle difference - the use of DATE_FORMAT in findDate and DATE_TIME_FORMAT in findDateTime. We need both formats to be represented, so we can't merge this in as is. However, If you'd like to write up a function with the signature public Calendar findCalendar(String expression, String format) that both findDate and findDateTime can use, that could be a worthwhile change. I'm going to close this for now, but please reopen it if you get the time to refactor.