braintree / braintree_java

Braintree Java library

https://developer.paypal.com/braintree/docs/start/overview

MIT License

158 stars 99 forks source link

[PayPal] Billing Address For Payer Info #83

Closed eliasjpr closed 4 years ago

eliasjpr commented 4 years ago

Summary

We at the New York Times are in need of retrieving the billing address for a given Billing Agreement Nonce using the Vault Flow.

We would like to propose the follow changes to satisfy this need.

Changes

Adds Address object to enable retrieval of the PayPal Billing Address from the backend.

Side Effects

Can expect the Billing Address to be populated from the Billing Address found in PayPal.

Example Screen Shot 2020-03-19 at 11 43 17 AM

Checklist

[x] Added changelog entry
[x] Ran unit tests (mvn verify -DskipITs)

eliasjpr commented 4 years ago

@braebot @dan-manges I would be happy to add unit and integration tests if the changes are acceptable.

eliasjpr commented 4 years ago

Sounds good. Let me know if you need anything on our end.

hollabaq86 commented 4 years ago

@eliasjpr We wanted to send a quick heads up, we're building on this work you submitted. The main change we're making is to use international address labels, so getCity -> getLocality. This way it's in parity with other Address objects returned by our API.

eliasjpr commented 4 years ago

Thanks for the heads up. I have informed my team about this change.

hollabaq86 commented 4 years ago

Hi @eliasjpr Happy friday! We just merged in our updates with your work to master, and plan to include this in the next release (which we're hoping to do next week). I'm going to go ahead and close this PR, thanks again for your contribution 😃

crookedneighbor commented 4 years ago

This is out in 2.109.0 https://github.com/braintree/braintree_java/commit/3cf022e01a8598c658a0c25d847f42838471c781