Closed ghost closed 3 years ago
I'm not sure what more is needed for this PR to be accepted. I didn't see any unit tests for the affected code change and I don't think I can run the integration tests as per DEVELOPMENT.md.
👋 @iainjames88 Thanks for the PR! Integration tests are run in an internal development environment at Braintree, we'll take a look at how our tests need to be updated with these changes for the next release.
👋 @iainjames88 Thanks for the PR! Integration tests are run in an internal development environment at Braintree, we'll take a look at how our tests need to be updated with these changes for the next release.
Thanks :) When do you think the next release with these changes will be?
When do you think the next release with these changes will be?
With Thanksgiving being next week, it's tough to give an ETA. My general hope is sooner than later if that helps! We'll post updates here when we're closer to releasing the next version.
Hey @iainjames88 we just merged in your changes (with some additional testing 😃 ) and hope to cut a release this week. A few other PRs came into this repo that we'd like to review first.
Awesome tyvm @hollabaq86 :)
@iainjames88 version 3.4.0 is out with these changes. Thanks again for the PR!
Summary
Hello 👋 When trying to construct a
PaymentMethodNonce
from the XML response inPaymentMethodNonceGateway::find
the constructor forThreeDSecureInfo
is looking in the wrong place for the 3DS info. It's trying to load it from a node calledauthenticate
when it's actually calledauthentication
. The XML looks likeChecklist
mvn verify -DskipITs
)