braintree / braintree_java

Braintree Java library
https://developer.paypal.com/braintree/docs/start/overview
MIT License
158 stars 98 forks source link

ThreeDSecureInfo gets auth data from correct XML node #87

Closed ghost closed 3 years ago

ghost commented 3 years ago

Summary

Hello 👋 When trying to construct a PaymentMethodNonce from the XML response in PaymentMethodNonceGateway::find the constructor for ThreeDSecureInfo is looking in the wrong place for the 3DS info. It's trying to load it from a node called authenticate when it's actually called authentication. The XML looks like

<?xml version="1.0" encoding="UTF-8"?>
<payment-method-nonce>
  <three-d-secure-info>
    <authentication>
      <trans-status nil="true"/>
      <trans-status-reason nil="true"/>
    </authentication>
  </three-d-secure-info>
</payment-method-nonce>

Checklist

ghost commented 3 years ago

I'm not sure what more is needed for this PR to be accepted. I didn't see any unit tests for the affected code change and I don't think I can run the integration tests as per DEVELOPMENT.md.

hollabaq86 commented 3 years ago

👋 @iainjames88 Thanks for the PR! Integration tests are run in an internal development environment at Braintree, we'll take a look at how our tests need to be updated with these changes for the next release.

ghost commented 3 years ago

👋 @iainjames88 Thanks for the PR! Integration tests are run in an internal development environment at Braintree, we'll take a look at how our tests need to be updated with these changes for the next release.

Thanks :) When do you think the next release with these changes will be?

hollabaq86 commented 3 years ago

When do you think the next release with these changes will be?

With Thanksgiving being next week, it's tough to give an ETA. My general hope is sooner than later if that helps! We'll post updates here when we're closer to releasing the next version.

hollabaq86 commented 3 years ago

Hey @iainjames88 we just merged in your changes (with some additional testing 😃 ) and hope to cut a release this week. A few other PRs came into this repo that we'd like to review first.

ghost commented 3 years ago

Awesome tyvm @hollabaq86 :)

hollabaq86 commented 3 years ago

@iainjames88 version 3.4.0 is out with these changes. Thanks again for the PR!