braintree / braintree_java

Braintree Java library

https://developer.paypal.com/braintree/docs/start/overview

MIT License

158 stars 99 forks source link

Re-use patterns, Avoid compiling / creating pattern when not needed #91

Closed benbenw closed 3 years ago

benbenw commented 3 years ago

Summary

Re-use patterns Avoid compiling / creating pattern when not needed (String#replaceAll) No need to do the compilation each time : Pattern are thread safe

Already covered by tests except for EnumUtils where a test was missing (added)

Checklist

[X] Added changelog entry
[X] Ran unit tests (mvn verify -DskipITs)

jplukarski commented 3 years ago

👋 @benbenw We have merged your changes and they will be available in the next release. Thanks again for the PR!