search

braintree / braintree_java

Braintree Java library
https://developer.paypal.com/braintree/docs/start/overview
MIT License
158 stars 99 forks source link

Incorrect logging level for the HTTP client #97

Open mariuszdubielecki opened 3 years ago

mariuszdubielecki commented 3 years ago

In the HTTP client class com.braintreegateway.util.Http it is used INFO log level for logging every request which is sent to Braintree. This would produce a certain amount of logs on the server.

When you look at the documentation for INFO level java.util.logginghttps://docs.oracle.com/javase/8/docs/api/java/util/logging/Level.html#INFO

It says Typically INFO messages will be written to the console or its equivalent. So the INFO level should only be used for reasonably significant messages that will make sense to end users and system administrators.

I don't believe that sending a request to Braintree is the "significant message". It may be useful for debugging issues but not for every day usage.

hollabaq86 commented 3 years ago

👋 @mariuszdubielecki thanks for reaching out! You do raise a good point around our logging. We're going to leave this open and flag for review when we work on the next major version of this SDK.

hollabaq86 commented 2 years ago

for internal note-keeping, ticket 719