cloneTransaction has incorrect return type in @types/braintree

braintree / braintree_node

Braintree Node.js library

https://developer.paypal.com/braintree/docs/start/overview

MIT License

334 stars 104 forks source link

cloneTransaction has incorrect return type in @types/braintree #169

Closed jamemackson closed 4 years ago

jamemackson commented 4 years ago

General information

SDK/Library version:
- @types/braintree: 2.22.0
- braintree: 2.22.0
Environment: any
Language, language version, and OS: Node 12 (any version) on MacOS

Issue description

In @types/braintree the defined return type for cloneTransaction is set to Promise<void> when in actuality it returns something like Promise<ValidatedResponse<Transaction>>.

crookedneighbor commented 4 years ago

We don't maintain @types/braintree.

In a release in the future, the Braintree Node SDK will be converted to typescript and have its own types. Until then, you may PR definitely typed to fix the @types/braintree package.

jamemackson commented 4 years ago

Thanks @crookedneighbor. Good to know. 👍