Expected types of Subscription.billingPeriodStartDate and Subscription.billingPeriodEndDate

braintree / braintree_node

Braintree Node.js library

https://developer.paypal.com/braintree/docs/start/overview

MIT License

334 stars 104 forks source link

Expected types of Subscription.billingPeriodStartDate and Subscription.billingPeriodEndDate #190

Closed fightbulc closed 3 years ago

fightbulc commented 3 years ago

General information

SDK/Library version: 3.3.0
Environment: Both
Language, language version, and OS: 12.22.1

Issue description

I would like to find out what should be the expected types of the aformentioned fields. @types/braintree defines Date, your website docs leave that empty and the actual response is a string.

Would be great to see what we should expect here.

Looking forward to hearing back from you.

sestevens commented 3 years ago

The expected type for both of those fields is a string. We'll look into updating the docs so that's more clear!

fightbulc commented 3 years ago

Thanks for making this clear, @sestevens

sestevens commented 3 years ago

The docs updates will be published soon, so I'm going to close out this issue. Thanks for bringing this to our attention!