Closed briandotdev closed 5 years ago
Hey @briandotdev, we saw this as well when doing some testing in PHP 7. At this time, since we need to support PHP 5, we can't make a sweeping update to the latest version of phpunit. However, PHP 5 ceases getting security updates at the end of this year, so we're planning on releasing a major version of this SDK that drops support for PHP 5 and updates PHPunit to the latest version.
If you want to open the PR with the changes you've made, we're happy to build off that PR. It will certainly make the transition quicker once we can release the major version.
Thanks for the response @crookedneighbor. Also note that PHP 7.1 has already stopped receiving security updates so it will be a big jump! PHPUnit 6 is also ending support soon so v7 will be the way to go. Hopefully this helps get things started. #240
This should be fixed in v4.0.0 which requires PHP 7.2.0 or higher
This library currently requires PHPUnit version
3.7.*
. This version of PHPUnit is not compatible with PHP 7.3 and unit tests currently fail to run. I had a PR all queued to to bump the PHPUnit version to 7.5 until I noticed that your integration tests require a proprietary test environment so I'm unable to verify they execute correctly under PHPUnit 7.5.I'm happy to PR the changes I've made to migrate the unit tests to version 7.5 if you have a desire to complete the migration of integration tests. As it stands now tests are broken under PHP 7.3.
High level changes I've made: