search

braintree / braintree_php

Braintree PHP library
https://developer.paypal.com/braintree/docs/start/overview
MIT License
546 stars 224 forks source link

Wrong phpDoc type for Dispute search parameter #268

Closed pupitooo closed 4 years ago

pupitooo commented 4 years ago

In documentation of Dispute::search() is using of search in this format (accepts array):

$collection = $gateway->dispute()->search([
  Braintree\DisputeSearch::id()->is('dispute_id')
]);

but DisputeGateway.php accepts (by phpDoc) DisputeSearch only: https://github.com/braintree/braintree_php/blob/f32fece534cce96cdbe9c0c6bd5af12469333900/lib/Braintree/DisputeGateway.php#L245

Can you fix this?

crookedneighbor commented 4 years ago

Good catch. Would you like to open a PR to fix it?