braintree / braintree_php

Braintree PHP library

https://developer.paypal.com/braintree/docs/start/overview

MIT License

546 stars 224 forks source link

Braintree Configuration errors handling, that is, when user has not set even one of the configuration requirement. #279

Closed Gicehajunior closed 4 years ago

Gicehajunior commented 4 years ago

Summary

Checklist

[x] Added changelog entry
[x] Ran unit tests (Check the README for instructions)

crookedneighbor commented 4 years ago

I could be reading your logic incorrectly, but it looks to me like you've written it so a configuration error will be thrown if all the required configuration parameters are set. Which, I think, is the opposite of what you intended :)

Gonna close this, because I don't think this PR is necessary, but if I missed something, feel free to comment about it.

Gicehajunior commented 4 years ago

I understand your logic too, you are right. I have just changed my logic and did put in another way to what i intended to. Kindly try checking it out and have me a response. Thanks.