search

braintree / braintree_php

Braintree PHP library
https://developer.paypal.com/braintree/docs/start/overview
MIT License
547 stars 224 forks source link

invalid keys: lineItems[imageUrl] #293

Closed EvilLooney closed 1 year ago

EvilLooney commented 3 years ago

General information

Issue description

Hello,

Based on your documentation, it says we can add a product image url for line items: https://developers.braintreepayments.com/reference/request/transaction/sale/php#line_items.image_url

But doing so throws an InvalidArgumentException.

I looked at the code and cannot find a reference to that key.

So my question is, is this an error in the docs or an error in the code base?

Thanks.

hollabaq86 commented 3 years ago

👋 Thanks for reaching out, looks like the docs got updated before the SDK, sorry about that. Want to PR it?

EvilLooney commented 3 years ago

Hi Holly,

I literally just installed the package this morning. So no, I am not comfortable doing a PR at this time.

Sorry!

hollabaq86 commented 3 years ago

@EvilLooney no worries! We'll get this added to the SDK 😄

hollabaq86 commented 1 year ago

this was actually a mistake in the docs, and is now removed. Apologies for the delay and confusion