search

braintree / braintree_php

Braintree PHP library
https://developer.paypal.com/braintree/docs/start/overview
MIT License
545 stars 225 forks source link

Add more subscription xml samples for test cases #295

Closed antonvolokha closed 3 years ago

antonvolokha commented 3 years ago

Summary

Hi I make unit tests using WebhookTestingGateway::sampleNotification function and I found that the subscription object didn`t have status property so I added it because for me this property is very important and I olso added samples xml for types:

If these changes do not suit for you, explain how to test this types of notification without it ?

Checklist

sestevens commented 3 years ago

@antonvolokha, thanks for opening this PR! I left a few small suggestions about the method names, but overall this change looks good me. 👍

antonvolokha commented 3 years ago

Thanks @sestevens! I apply all your suggestions

sestevens commented 3 years ago

Thanks for opening this PR -- we merged your commits and this will go out in the next release!

sestevens commented 3 years ago

This was released in version 6.1.0.