Add @property for magic getters in Results

braintree / braintree_php

Braintree PHP library

https://developer.paypal.com/braintree/docs/start/overview

MIT License

547 stars 224 forks source link

Add @property for magic getters in Results #311

Closed colorninja closed 1 year ago

colorninja commented 2 years ago

General information

SDK/Library version: 6.5.1
Environment: Both
Language, language version, and OS: PHP 8.1 - Linux amd64

Issue description

PHPStan is going mental when analysing analysing results from $gateway->transaction()->sale(...), because there are no doocs. Would be nice there was PHPDoc @property annotations on at least Transaction and Error classes.

slt commented 2 years ago

Hi I am having this same issue - seems to be the same as issue #310 These did exist prior to 6.5.0 but were stripped out in https://github.com/braintree/braintree_php/commit/e35c2a2d74a10e9cec5932506486e4b8bccfa4ba

hollabaq86 commented 1 year ago

Hey folks, going to close this issue as it is the same as #310. Will move conversation there