braintree / braintree_python

Braintree Python library
https://developer.paypal.com/braintree/docs/start/overview
MIT License
242 stars 115 forks source link

Increase granularity in TimeoutError #105

Closed bhargavrpatel closed 5 years ago

bhargavrpatel commented 6 years ago

Summary

Context

Increase the granularity of TimeoutError by introducing child classes, ConnectTimeoutError and ReadTimeoutError to parity the exceptions raised from the requests library.

Changes

References

https://github.com/braintree/braintree_python/issues/104

Checklist

bhargavrpatel commented 6 years ago

Not sure if the tag needs to be generated on the braintree repo or on my fork.

Also note that I am not entirely sure if we needed Unit tests here given that I only saw an integration test for the timeout behavior.

Finally, do let me know if any changes need to be made. I'd be happy to make them promptly.

Thank you once more.

bhargavrpatel commented 5 years ago

@crookedneighbor I went ahead and rebased the branch with upstream and recreated the branch and applied the changes.