braintree / braintree_python

Braintree Python library

https://developer.paypal.com/braintree/docs/start/overview

MIT License

241 stars 155 forks source link

Include tests in PyPI tarball #111

Closed ghost closed 5 years ago

ghost commented 5 years ago

Summary

I want to package this library for NixOS, including the tests in the pypi tarball will help integrating it.

Checklist

[ ] Added changelog entry
[ ] Ran unit tests (nosetests tests/unit)

crookedneighbor commented 5 years ago

Can you explain why the tests need to be added to the pypi tarball? I can't think of a situation where that would be beneficial.

ghost commented 5 years ago

It's useful for NixOS to test if the package works correctly with the build recipe. Also, it provides a way to test if the packaged dependencies are compatible. It's also useful to many other distributions that rely on source and binary distribution of packages.

crookedneighbor commented 5 years ago

I find it strange to include the tests as part of the binary. That bloats the size, and the only time you'd ever run the tests would be during development, which you would do from source, not using the binary.

Also, the integration tests rely on specific development only architecture that is private to Braintree's setup, so the integration tests will never pass for anyone using this repo outside of the Braintree organization.

Because of both of these things, I'm going to close this pull request.