braintree / braintree_python

Braintree Python library
https://developer.paypal.com/braintree/docs/start/overview
MIT License
241 stars 155 forks source link

Use unittest instead of nose #146

Closed arthurzam closed 1 year ago

arthurzam commented 1 year ago

Summary

nose is considered deprecated, and has various issues. After some reviewing of nose usage in this library, I noticed that it is very easy to use builtin unittest functionality for it (to use assertRaises and assertRaisesRegex instead)

Also, mock is unnecessary, as you already use unittest.mock everywhere.

I have updated the docs and scripts to use python3 -m unittest discover instead of nosetests.

Checklist

saralvasquez commented 1 year ago

Thanks for the PR! We will take a look and get back to you with any feedback/questions

crookedneighbor commented 1 year ago

We've dedicated some time in a few weeks to look over this and get it merged in. Thanks so much for noticing this and making the changes.

crookedneighbor commented 1 year ago

Thanks so much for this work @arthurzam !