Expose error details in "UnexpectedException" in Python library - Githubissues

braintree / braintree_python

Braintree Python library

https://developer.paypal.com/braintree/docs/start/overview

MIT License

242 stars 115 forks source link

Expose error details in "UnexpectedException" in Python library #156

Open charlie-zhang109 opened 3 months ago

charlie-zhang109 commented 3 months ago

General information

SDK/Library version:4.28.0
Environment: Production

Issue description

When our backend tried to create a customer on BT side, we got the following UnexpectedError without a detailed message.

raise UnexpectedError("Unexpected HTTP_RESPONSE " + str(status))
braintree.exceptions.unexpected_error.UnexpectedError: Unexpected HTTP_RESPONSE 400

From this BT doc, looks like the client library needs to handle it.

Also Java library had this similar issue and it got fixed.

It would be helpful if that error was bubbled up to the exception, or generated a more specific exception like the Java library.

charlie-zhang109 commented 3 months ago

Could someone take a look? It prevents our customer adding their credit cards so we're losing revenue. Thanks!