setup.py improvements - Githubissues

braintree / braintree_python

Braintree Python library

https://developer.paypal.com/braintree/docs/start/overview

MIT License

242 stars 115 forks source link

setup.py improvements #73

Closed adamchainz closed 7 years ago

adamchainz commented 7 years ago

I visited the PyPI page as I was looking at dependencies to upgrade and found it a little bare, so I've made these changes:

Include README so visitors to PyPI page can find links easily. This requires converting the README to reStructuredText since that's all PyPI supports.
Add a link from the README direct to the Github repository, since the url field is used to link to the braintree docs.
Use setuptools rather than distutils, because the future is now.

jackellenberger commented 7 years ago

Hi @adamchainz,

While the package is available on PyPI we're expecting GitHub to be the primary source for build instructions, best practices, and revision history. For full documentation, we do prefer developers visit the Braintree docs. We're not going to merge these changes at this time, but we appreciate your contribution! We often talk about how we package our READMEs and other documentation for increased visibility and clarity; we will take your input into account in our next discussion.

adamchainz commented 7 years ago

You should still link to github from PyPI. You only have the changelog on Github and it's a pain to find it otherwise. When I upgrade packages I first look at all their PyPI pages and try to find their changelogs from there.

Also you should definitely be using setuptools, it's the one under active development...