Closed bjackson closed 5 years ago
Hey @bjackson, would you mind expanding a little more on what your use case is for this? There is currently a way to provide an id when generating a sample webhook notification that I think could fill the same role as the id this PR introduces, but I may be misinterpreting what you're looking to do.
Looking at your PR @bjackson ! It looks like you meant adding SubscriptionChargedUnsuccessfully
and NOT SubscriptionChargedSuccessfully
. Is that correct ?
@jaypatel512, Yes. I mistyped.
@jackellenberger, in my codebase, I was capturing transactions and their IDs. The transactions in the sample webhook notifications didn't include an ID attribute on them, and caused my tests to fail.
Summary
I added a random ID to the Transaction in the webhook. I think many usages of this library might capture the ID on a Transaction, and this would help support unit testing.
Checklist
nosetests tests/unit
)