search

braintree / braintree_ruby

Braintree Ruby library
https://developer.paypal.com/braintree/docs/start/overview
MIT License
444 stars 195 forks source link

Wrong error code constants #213

Closed shaunma closed 3 years ago

shaunma commented 3 years ago

Error codes 93106 and 93107's constant names are flipped.

https://github.com/braintree/braintree_ruby/blob/fa974389eddb9f5b8f414f88e226f4868b4921e7/lib/braintree/error_codes.rb#L712

https://github.com/braintree/braintree_ruby/blob/fa974389eddb9f5b8f414f88e226f4868b4921e7/lib/braintree/error_codes.rb#L706

PaymentMethodNonceConsumed should be 93107 CannotForwardPaymentMethodType should be 93106

scannillo commented 3 years ago

Hi @shaunma - thank you for catching this. You are correct! We will get this cleared up in the Ruby SDK.

Body87 commented 3 years ago

Имена постојаних кодова грешака 93106 и 93107 се преокрећу.

https://github.com/braintree/braintree_ruby/blob/fa974389eddb9f5b8f414f88e226f4868b4921e7/lib/braintree/error_codes.rb#L712

https://github.com/braintree/braintree_ruby/blob/fa974389eddb9f5b8f414f88e226f4868b4921e7/lib/braintree/error_codes.rb#L706

ПаиментМетходНонцеЦонсумед треба да буде 93107 ЦаннотФорвардПаиментМетходТипе треба да буде 93106

scannillo commented 3 years ago

👋 Hello @shaunma & @Body87 - we released a fix for this in Braintree Ruby v4.1.0. Thank you for opening the issue!