search

braintree / credit-card-type

A library for determining credit card type
MIT License
980 stars 154 forks source link

add Dankort support #106

Closed cassiocardoso closed 4 years ago

cassiocardoso commented 4 years ago

Hi!

I was working on integrating this lib into another one that I'm maintaining and noticed that you had the Dankort issue flag tagged as help wanted, so here it is. 😄

Since the changes are mostly in the card configuration and docs, I think this won't have a negative impact on the TS migration you've been working on.

Let me know if there's anything else needed.

Proposal

Add Dankort support. (closes #100)

Details

crookedneighbor commented 4 years ago

We can't accept this without official documentation about the dankort ranges. Please provide that.

cassiocardoso commented 4 years ago

Hey @crookedneighbor I thought this references would be enough from your comments on the thread

crookedneighbor commented 4 years ago

LOL, you're right. Totally forgot the reference was in the original issue.

cassiocardoso commented 4 years ago

haha no worries :)

cassiocardoso commented 4 years ago

Hi @gesa, thanks for your review! Sounds good to me, let me know once the TS migration is merged and I can update this one :)

crookedneighbor commented 4 years ago

The typescript migration is complete.

crookedneighbor commented 4 years ago

Going to close this for now, but once you've merged in master, feel free to open a new PR.