Closed cassiocardoso closed 4 years ago
We can't accept this without official documentation about the dankort ranges. Please provide that.
Hey @crookedneighbor I thought this references would be enough from your comments on the thread
LOL, you're right. Totally forgot the reference was in the original issue.
haha no worries :)
Hi @gesa, thanks for your review! Sounds good to me, let me know once the TS migration is merged and I can update this one :)
The typescript migration is complete.
Going to close this for now, but once you've merged in master, feel free to open a new PR.
Hi!
I was working on integrating this lib into another one that I'm maintaining and noticed that you had the Dankort issue flag tagged as
help wanted
, so here it is. 😄Since the changes are mostly in the card configuration and docs, I think this won't have a negative impact on the TS migration you've been working on.
Let me know if there's anything else needed.
Proposal
Add
Dankort
support. (closes #100)Details
Dankort
type.