[#100] add support for Dankort card type

braintree / credit-card-type

A library for determining credit card type

MIT License

980 stars 154 forks source link

[#100] add support for Dankort card type #125

Closed mahendraHegde closed 3 years ago

mahendraHegde commented 3 years ago

This PR closes #100

Adds support for Dankort Credit card
updates relevant tests
updates readme
some unexpected lint related updates 😆

mahendraHegde commented 3 years ago

@crookedneighbor plz review

crookedneighbor commented 3 years ago

After re-reviewing the documentation links provided in the original issue, I'm not comfortable with merging this in until we have actual documentation around the bin ranges for this card. (the documentation provided was simply a test number for Dankort, not any official description of what the expected bin ranges are)

I'll bring this up with Braintree's cards team to see if they have any insight as well.

crookedneighbor commented 3 years ago

So, according to our cards team, 5019 is technically a card that should be cobranded with Mastercard. And there are Dankort cards that are cobranded with visa as well, so I don't think this PR is sufficient as is to include, because it doesn't account for cobranded visa cards or standalone Dankort cards.

If you can provide official and comprehensive documentation for Dankort cards, we can definitely revisit this.