update discover exactPattern

braintree / credit-card-type

A library for determining credit card type

MIT License

980 stars 154 forks source link

update discover exactPattern #53

Closed pmoalmeida closed 7 years ago

pmoalmeida commented 7 years ago

Based on the source below* there are a few card numbers that are not evaluated as a Discover card, such as the ones beginning with 6221 or 6229.

https://www.getnewidentity.com/discover-credit-card.php

crookedneighbor commented 7 years ago

Can you provide documentation from Discover?

pmoalmeida commented 7 years ago

All the information I've got on this are these links:

https://www.discover.com/credit-cards/resources/what-is-a-credit-card-number
http://www.creditcards.com/credit-card-news/credit-card-appearance-1268.php (this was obtained by clicking on MIIs link on the source above)
https://creditcardjs.com/credit-card-type-detection

Where else should I find the latest official info on this though?

lilaconlee commented 7 years ago

The bin ranges you've added are currently identified as UnionPay cards by the Braintree gateway, so we're going to keep this library in line with that. If that behavior changes, we'll update this library. Thanks for the PR though!