Closed petecraven91 closed 5 years ago
@crookedneighbor all valid points. I've made the suggested changes I agree this is the ideal time to add testing for each function, just don't have the time to do it right now but can look at doing this for future pull requests
Thanks Updated to kebab case
I don't care that much.
Usually, if it's a small function, all I'll just do: module.exports = function () {}
and if it's longer, I'll name it.
Will work on adding some additional tests for this on Friday.
Didn't get a chance to work on this last week like I'd hoped. Will try to get this merged in this week.
Merged in with https://github.com/braintree/credit-card-type/commit/32c92e97ad6d5857839872791391d38db64548c1
Made a few choices to combine some files. For instance, the matchesPattern
and matchesRange
functions could be considered private methods of the matches
module, so I moved them in there and made sure to test both cases in the test file for matches
.
Thanks for doing this chore!
Refactored the code so it isn't all in one file. broke out functions and the card types