Add Live Demo - Githubissues

braintree / credit-card-type

A library for determining credit card type

MIT License

980 stars 154 forks source link

Add Live Demo #92

Closed KimGenius closed 5 years ago

KimGenius commented 5 years ago

Hi!

Thank you so much to made good library

I think so this library need Live Demo code link in README ! So, i made Live Demo with Code sandbox

If you think like me, please merge this pull request!

Thank you!

demerino commented 5 years ago

@KimGenius Thanks for the thoughtful demo and PR! This seems like a great idea, we'll review the demo and see what is the best path forward for linking to live demos.

crookedneighbor commented 5 years ago

I like the idea of adding a demo, but I think it should:

A) be presented in this repo through Github Pages so it can be reached at https://braintree.github.io/credit-card-type

B) be framework agnostic, not specifically React

crookedneighbor commented 5 years ago

Going to close this for now, but if you'd like to submit a new PR that meets the criteria I laid out, go for it.