search

braintree / curator

Model and repository framework
MIT License
350 stars 39 forks source link

Riak client upgrade #54

Closed SavithaK closed 8 years ago

SavithaK commented 8 years ago

PR for https://github.com/braintree/curator/issues/53

@pgr0ss @bmorton @chrismohr

SavithaK commented 8 years ago

@pgr0ss tests failed because of they couldn't connect to pb port 8087. This is because of : +1: [0K$ sudo service riak start !!!! !!!! WARNING: ulimit -n is 1024; 65536 is the recommended minimum. !!!!

I noticed this locally that without the right ulimit, riak keeps crashing after it has started. Any idea how travis can be configured to set this up correctly?

pgr0ss commented 8 years ago

I've had a lot of problems with riak on travis. You could try adding an /etc/default/riak in a before_install:

https://github.com/travis-ci/travis-ci/issues/3328 https://docs.travis-ci.com/user/installing-dependencies/

SavithaK commented 8 years ago

Don't seem to be having luck with before install :(

SavithaK commented 8 years ago

@pgr0ss I finally got some time to look into it and get it working. Mind if we stop supporting 1.9.3 from now on? I am not sure why installing it fails, but I am guessing its old enough that we can safely stop supporting it?

I 'll do another PR to upgrade rails and ruby versions. This one upgrades riak client and removes ruby 1.9.3 support

SavithaK commented 8 years ago

@pgr0ss if you're good with this please merge it.

SavithaK commented 8 years ago

Hullo @pgr0ss! Any thoughts on merging this in?

pgr0ss commented 8 years ago

Sorry for the slow reply. Thanks for upgrading the client!

SavithaK commented 8 years ago

Thanks @pgr0ss :)

SavithaK commented 8 years ago

@pgr0ss Also when you get a chance, could you bump the version?

pgr0ss commented 8 years ago

Done.