Closed ahayworth closed 6 years ago
@ssgelm Some feedback addressed. Honestly, downloading the stretch VM keeps timing out for me. Maybe we should run it on ubuntu? Thoughts?
@ahayworth perhaps vagrant's mirrors were having issues, I tried https://app.vagrantup.com/debian/boxes/contrib-stretch64 this morning and it pulled down without issue.
Any reason not to do this in Docker, instead of Vagrant?
@zdzolton The one nice thing that Vagrant gives you over Docker for development is the relative ease of setup - you just run vagrant up && vagrant ssh
and you're done. Docker is a bit more irritating: you have to build, then exec, make sure you map volumes and ports, etc.
That said, I know I'm permanently stuck in yesteryear's technologies. I updated the commit to use a Dockerfile instead of a Vagrantfile - because I think it's probably a better choice.
@lollipopman @ssgelm I rebuilt this in Docker and used Stretch.
Coordinating with @ahayworth I've pushed some changes to address @ssgelm's feedback, and also add instructions for running the agent checks in a container. If this looks good I think it's ready to merge.
It's useful to be able to get a VM with dependencies built and installed, and also to play around with the service.
The worst part of all of this is that things like
bin/litmus
andbin/litmusctl
expect the litmus gem to be installed (and hence we build/install it in the vm). Future work should make this run from the checkout w/o actually installing the gem.