search

braintree / manners

A polite Go HTTP server that shuts down gracefully.
MIT License
997 stars 103 forks source link

allow access to the inner http server so its settings can be tweaked #20

Closed kmanley closed 10 years ago

kmanley commented 10 years ago

A simple, API-backward-compatible change that allows the inner http.Server to be tweaked. For example, by setting 

InnerServer.ReadTimeout = x * time.Second

issue #19 is solved.

lionelbarrow commented 10 years ago

:thumbsup:

lionelbarrow commented 10 years ago

In https://github.com/braintree/manners/pull/22/ we will start just embedding the http.Server directly in the struct, so you won't call InnerServer anymore.

kmanley commented 10 years ago

Even better, thanks @lionelbarrow!