search

braintree / manners

A polite Go HTTP server that shuts down gracefully.
MIT License
997 stars 103 forks source link

Please merge non-backwards-compat #26

Closed FiloSottile closed 9 years ago

FiloSottile commented 9 years ago

I've been reviewing the non-backwards-compat branch, and it looks like the perfect implementation of a no-timeout graceful-stopping http.Server. Is there anything stopping it from becoming master?

Thanks for the work!

lionelbarrow commented 9 years ago

I've been chipping away at trying to merge it off and on. My main issue is that I want to rewrite the tests to be easier to understand, and it makes some changes to the API that I'm not sure about.

I suppose I can merge it in and then rewrite the tests later. I'll look into that over the weekend.

lionelbarrow commented 9 years ago

Merge. I'm going to spend some time refactoring the tests.