braintree / pg_ha_migrations

Enforces DDL/migration safety in Ruby on Rails project with an emphasis on explicitly choosing trade-offs and avoiding unnecessary magic.
MIT License
220 stars 23 forks source link

Add tests to verify the behavior of disable_ddl_transaction #101

Closed rkrage closed 4 months ago

rkrage commented 4 months ago

With recent PRs / conversations around transactional migrations, I figured it would be a good idea to write some basic tests to verify existing behavior. In other tests, we execute test migrations directly which bypasses the transaction logic in AR.

rkrage commented 4 months ago

Can you squash into the two meaningful commits after applying the one suggestion?

Done and done