search

braintree / pg_ha_migrations

Enforces DDL/migration safety in Ruby on Rails project with an emphasis on explicitly choosing trade-offs and avoiding unnecessary magic.
MIT License
220 stars 23 forks source link

Make error classes inherit from StandardError not Exception #66

Closed jcoleman closed 2 years ago

jcoleman commented 3 years ago

The error classes are named with the suffix Error anyway, so it's confusing that they inherit from Ruby's Exception class. That's not a nice surprise since Exception is conventionally special in the Ruby world.

That being said we don't expect anyone to be rescuing these errors, but it seems unnecessary to prevent it this way.