Closed 14113 closed 1 year ago
In the method unsafe_make_column_not_nullable, it's called safely_acquire_lock_for_table.
unsafe_make_column_not_nullable
safely_acquire_lock_for_table
Is the prefix unsafe_ correct?
https://github.com/braintree/pg_ha_migrations/blob/92ec97c9ffca4785b48ca84bb71afb914e827776/lib/pg_ha_migrations/safe_statements.rb#L143-L147
Yes. You might see a mix of safe and unsafe calls in the implementation of various methods, but that doesn't change the overall safety of the operation
In the method
unsafe_make_column_not_nullable
, it's calledsafely_acquire_lock_for_table
.Is the prefix unsafe_ correct?
https://github.com/braintree/pg_ha_migrations/blob/92ec97c9ffca4785b48ca84bb71afb914e827776/lib/pg_ha_migrations/safe_statements.rb#L143-L147