search

braintree / pg_ha_migrations

Enforces DDL/migration safety in Ruby on Rails project with an emphasis on explicitly choosing trade-offs and avoiding unnecessary magic.
MIT License
220 stars 23 forks source link

Unsafe make_column_not_nullable #82

Closed 14113 closed 1 year ago

14113 commented 1 year ago

In the method unsafe_make_column_not_nullable, it's called safely_acquire_lock_for_table.

Is the prefix unsafe_ correct?

https://github.com/braintree/pg_ha_migrations/blob/92ec97c9ffca4785b48ca84bb71afb914e827776/lib/pg_ha_migrations/safe_statements.rb#L143-L147

rkrage commented 1 year ago

Yes. You might see a mix of safe and unsafe calls in the implementation of various methods, but that doesn't change the overall safety of the operation