braintree / popup-bridge-ios

Enable your web view to open pages in an ASWebAuthenticationSession
MIT License
38 stars 20 forks source link

Hide protocol implementations from `POPPopupBridge` public API #51

Closed scannillo closed 1 year ago

scannillo commented 1 year ago

Summary of changes

Note:

Authors

@scannillo

scannillo commented 1 year ago

Boo - these errors are because I was using features only avail in Xcode 14.3 ... working on it

scannillo commented 1 year ago

I'm closing this PR for a few reasons:

  1. The unit tests rely on these protocol implementations to be visible. We don't really have the time right now to be overhauling the unit test setup for popup bridge.
  2. This solution is an additional layer of complexity when our goal is just to convert the module to swift for now.

Will follow-up with a simpler PR to just "hide" the methods not meant to be included in the public API. At a later time we can revisit this approach.