search

braintree / popup-bridge-ios

Enable your web view to open pages in an ASWebAuthenticationSession
MIT License
38 stars 20 forks source link

Fix bug launching PopupBridge from iFrame #64

Closed scannillo closed 8 months ago

scannillo commented 8 months ago

Summary of changes

Authors

@scannillo @ravishekhar

scannillo commented 8 months ago

Unit Tests are failing on main and look unrelated to the changes in this PR. Created a ticket for us to fix these on main - DTBTSDK-3662

scannillo commented 8 months ago

UI tests also passing locally on Xcode 15.3 on this branch.

scannillo commented 8 months ago

@jaxdesmarais - I think we are OK to merge this. The unit tests are also failing on main and the UI tests are passing locally, so none are related to these changes. Look OK to you? 🚀

jaxdesmarais commented 8 months ago

@scannillo yeah I am okay with merging with the failures. They were also failing here: https://github.com/braintree/popup-bridge-ios/pull/62 so seems unrelated.