braintree / restricted-input

Restrict <input>s to certain valid characters (e.g. formatting phone or card numbers)
https://braintree.github.io/restricted-input/
MIT License
68 stars 25 forks source link

Fix iOS stuttering (Round 2) #13

Closed crookedneighbor closed 8 years ago

crookedneighbor commented 8 years ago

We extracted the bulk of the Restricted Input logic into strategies.

The iOS strategy inherits from the default strategy and just has different behavior for attaching listeners.

The Android Chrome strategy inherits from the default strategy. The only addition is that it prevents the default event when pasting. Couldn't reproduce the pasting bug in Android Chrome, so we're removing the Android Chrome strategy logic until we can actually reproduce the bug.

We've re-enabled integration testing for iOS Safari, Android 4.4 and Android latest.

Manual Browser Testing

EvanHahn commented 8 years ago

Other than my comments, I am 👍 assuming browser testing goes well. Happy to help with that if needed.

crookedneighbor commented 8 years ago

I'm :+1: on calling it BaseStrategy

lilaconlee commented 8 years ago

Looks 🐈 to me, but I have relatively little context on formatting.

crookedneighbor commented 8 years ago

@mrak I think I addressed all your comments, but let me know if there is still something pending.

mrak commented 8 years ago

👍

EvanHahn commented 8 years ago

🎉🎉🎉