search

braintree / runbook

A framework for gradual system automation
MIT License
730 stars 43 forks source link

Upgrade Thor #51

Closed Jcambass closed 2 years ago

Jcambass commented 2 years ago

This patch raises the thor version to ~> 1.0. Rails 6.1 requires thor ~> 1.0, so it probably makes sense for us to also up our requirement.

 In Gemfile:
    rails (~> 6.1.4) was resolved to 6.1.4.1, which depends on
      railties (= 6.1.4.1) was resolved to 6.1.4.1, which depends on
        thor (~> 1.0)
ClashTheBunny commented 2 years ago

I'm going to try and run these tests by closing and opening this PR.

coopergillan commented 2 years ago

@pblesi @ClashTheBunny - what say you?

ssgelm commented 2 years ago

This seems reasonable to me... I can't imagine anyone needing an older version of ruby.

ClashTheBunny commented 2 years ago

I'm good, we're well off ruby 1.x, which seems like the only major change jumping to Thor 1.x.

coopergillan commented 2 years ago

Thanks @Jcambass!