Fix: Check if url is null before proceeding

crookedneighbor commented 5 years ago

Released in v3.0.0

jLouzado commented 5 years ago

@crookedneighbor sorry to flog a dead horse but after doing a little more debugging I feel like my solution here is wrong; it might be better to explicitly throw a TypeError saying that the String is null.

imagine this package is used in an async/await function that waits on a future value of url
it's possible that maybe sanitizeUrl gets called before the function resolves, in which case url will be null
ideally you'd want this to throw an error explicitly so that there's no confusion about what's happened...

Right now, if v3.0.0 is in use the app won't break or throw an error or anything and it'll require an additional test to see what happens.

jLouzado commented 5 years ago

I was going to submit a second PR but got a little busy over the holidays 🙈

braintree / sanitize-url

Fix: Check if url is null before proceeding #10