search

braintree / sanitize-url

MIT License
312 stars 35 forks source link

Allow URLs to include accented characters #21

Closed edwinjoseph closed 4 years ago

edwinjoseph commented 4 years ago

Description

When sanitizing url with accents they get omitted from the return value. Ensure that urls with accents are allowed.

Fixes issue #20

Acceptance Criteria

crookedneighbor commented 4 years ago

Actually, I think this is missing some accent characters. Let me offer some PR suggestions.

crookedneighbor commented 4 years ago

@edwinjoseph ping

edwinjoseph commented 4 years ago

@edwinjoseph ping

Yup sorry, completely forgot. I've updated this and ran the tests, all good from my end.

crookedneighbor commented 4 years ago

This will go out with the next release.