search

braintree / sanitize-url

MIT License
312 stars 35 forks source link

Interest in type definitions? #4

Closed bufke closed 6 years ago

bufke commented 6 years ago

This module is so small - it would be trivial to add typescript type definitions. I'd be happy to submit them. Basically:

declare module "@braintree/sanitize-url" {
  export function sanitizeUrl(url: string): string;
};
crookedneighbor commented 6 years ago

We're not interested in adding them, but feel free to submit a PR to https://github.com/DefinitelyTyped/DefinitelyTyped yourself if you wish.

krzysztofzuraw commented 4 years ago

Hi 👋🏻 I've just added them: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43343

crookedneighbor commented 4 years ago

FYI, this module is now written in typescript.

PR to remove the types from DT: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46109