braintree / sanitize-url

MIT License
307 stars 35 forks source link

add esmodule export #51

Open vhoyer opened 1 year ago

hollabaq86 commented 1 year ago

Yeah it makes sense to esmodule support, but it would likely need to wait until we do a major version update of the library. Going to add this to our backlog, no ETA on when this work would get picked up.

for internal records, issue 2519

vhoyer commented 1 year ago

a major really? I feel like if could be a minor, albeit a big minor change, since we would only be adding the export, right? I don't think that adding the extra export would break the API in anyway.

hemry11 commented 10 months ago

a major really? I feel like if could be a minor, albeit a big minor change, since we would only be adding the export, right? I don't think that adding the extra export would break the API in anyway.

hemry11 commented 10 months ago

hello evry body i,m new here please i,m will come??

tcurdt commented 1 month ago

I also don't see why this would need a major release if it only adds exports. Is there something we are missing? 🤔