search

braintree / sanitize-url

MIT License
319 stars 37 forks source link

return str.replace(htmlEntitiesRegex, (match, dec : str.replace is not a function #54

Closed DNeelanshi closed 1 year ago

DNeelanshi commented 1 year ago

Null check is needed on str as its throwing error that str.replace is not a function

oscarleonnogales commented 1 year ago

HI @DNeelanshi,

Great observation, I see what you mean. Please feel free to submit a PR with this change if you'd like to contribute!

For internal tracking, DTBTSDK-2818

DNeelanshi commented 1 year ago

Thank you @oscarleonnogales for your response , I will try to contribute by forking to fix this issue .

DNeelanshi commented 1 year ago

please review PR https://github.com/braintree/sanitize-url/pull/56

oscarleonnogales commented 1 year ago

Thank you for starting the PR @DNeelanshi, I went ahead and did a few other changes along with your code and added you as a co-author for the final commit.

Closing this issue now as the PR has been merged and will be out in the next release.