search

brainvisa / aims-free

Analysis of Images and Signal for neuroimaging
Other
6 stars 3 forks source link

Fixes attribute handling within pydicom Dataset #95

Closed greydongilmore closed 1 year ago

greydongilmore commented 1 year ago

This adds handling for instances where a specified attribute is not found within the pydicom Dataset. For instance, if DICOM tag FrameReferenceTime is not found within the header the current behaviour will display Dataset does not have attribute 'FrameReferenceTime'. This PR fixes this issue by first checking if the attribute is found within the pydicom Dataset.

denisri commented 1 year ago

Same opinion as @sapetnioc, and as the changes don't look harmful and "competent people" are not available, I am in favor of merging this PR now, otherwise I fear it will never be done ?