search

brainvisa / axon

Brainvisa main GUI
Other
0 stars 1 forks source link

AnaLabelVolumeEditor fails to save new changes after the first save #80

Closed ylep closed 4 months ago

ylep commented 4 months ago

In BrainVISA 5.1.1, AnaLabelVolumeEditor fails to save new changes after the first save, because finalgraph.data/roi_Volume.nii is not overwritten by subsequent saves:

https://github.com/brainvisa/axon/blob/8b709cfeccdc0b5722f78d9bd5d8c57be31da2c3/brainvisa/toolboxes/tools/processes/roi/AnaLabelVolumeEditor.py#L147-L150

It seems that AimsGraphConvert fails to check for successful writing of the output graph:

https://github.com/brainvisa/aims-free/blob/v5.1.1/aimsdata/src/AimsGraphConvert/graphConvert.cc#L660-L672

The issue seems to date back to BrainVISA 4.5.1, in February 2017 (https://github.com/brainvisa/axon/commit/fc23efaa1a629c4c5b0102df1b53da32aaa0fd88).

denisri commented 4 months ago

Well, it's actually AimsGraphConvert which doesn't overwrite existing files in the .data directory. There is probably a force option which is missing. I'm looking at it.