search

brainvisa / casa-distro

Unified development environment for BrainVISA projects.
2 stars 1 forks source link

Add a software-only libGL in the casa-run-5.3 image #322

Closed ylep closed 1 year ago

ylep commented 1 year ago

We used to ship a software-only libGL in casa-run-5.0 but it was dropped during the upgrade to newer Ubuntu versions. Here it is back for the casa-run-5.3 image, but this time it is compiled during the creation of the image instead of being shipped pre-compiled (it is actually quite fast to compile).

This is part of an attempt to fix https://github.com/brainvisa/casa-distro/issues/321 but a software-only libGL could be useful in other scenarios.

I have built the new images and am ready to push them if you approve this PR :-)

codecov[bot] commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (brainvisa-5.1@da76b01). Click here to learn what that means. The diff coverage is n/a.

@@               Coverage Diff                @@
##             brainvisa-5.1     #322   +/-   ##
================================================
  Coverage                 ?   16.34%           
================================================
  Files                    ?       21           
  Lines                    ?     4031           
  Branches                 ?        0           
================================================
  Hits                     ?      659           
  Misses                   ?     3372           
  Partials                 ?        0
ylep commented 1 year ago

If you don't mind, I would prefer to wait until we better understand #321 before actually adding the software-only libGL: we still don't know if it is really required, or maybe the system-provided mesa can work with the LIBGL_ALWAYS_SOFTWARE environment variable? (see https://docs.mesa3d.org/envvars.html#envvar-LIBGL_ALWAYS_SOFTWARE)

denisri commented 1 year ago

So I let you test further using the LIBGL_ALWAYS_SOFTWARE env variable ?

ylep commented 1 year ago

LIBGL_ALWAYS_SOFTWARE does not ameliorate any of the issues described in https://github.com/brainvisa/casa-distro/issues/321.

As a result, I propose to include the software-only libGL in the image even though it does not help with older X2Go (4.0.0), because it still allows to fix glxinfo and glxgears (again, see https://github.com/brainvisa/casa-distro/issues/321).