search

brainwallet / brainwallet.github.io

Brainwallet site
https://brainwallet.org
291 stars 409 forks source link

Adds BIP39 to conversion #67

Closed mdurell closed 9 years ago

mdurell commented 9 years ago

This adds BIP39 to the conversion container though I'm sure there must be a way to easily slim-down bip39.js.

Please advise.

brainwallet commented 9 years ago

Not sure really. Yes, It's a way too big (~827 Kb).

mdurell commented 9 years ago

The smallest I could make it with various tools (Closure, minify, uglifyjs) was still 4x larger than jquery. I think the next step is using coverage tools to identify unused code and pull it out by hand.

There might be another related project that has already done this for the needed BIP39 conversions. I'll poke around and see if I can find anything. .

On Fri, Jan 2, 2015 at 2:33 AM, brainwallet notifications@github.com wrote:

Not sure really. Yes, It's a way too big (~827 Kb).

— Reply to this email directly or view it on GitHub https://github.com/brainwallet/brainwallet.github.io/pull/67#issuecomment-68515796 .

brainwallet commented 9 years ago

File too large (too many dependencies and unused code).